Re: [PATCH] PCI: qcom-ep: Do not enable resources during probe()
From: Krzysztof Wilczyński
Date: Tue Aug 13 2024 - 16:26:36 EST
Hello,
> Starting from commit 869bc5253406 ("PCI: dwc: ep: Fix DBI access failure
> for drivers requiring refclk from host"), all the hardware register access
> (like DBI) were moved to dw_pcie_ep_init_registers() which gets called only
> in qcom_pcie_perst_deassert() i.e., only after the endpoint received refclk
> from host.
>
> So there is no need to enable the endpoint resources (like clk, regulators,
> PHY) during probe(). Hence, remove the call to qcom_pcie_enable_resources()
> helper from probe(). This was added earlier because dw_pcie_ep_init() was
> doing DBI access, which is not done now.
>
> While at it, let's also call dw_pcie_ep_deinit() in err path to deinit the
> EP controller in the case of failure.
Applied to controller/qcom, thank you!
[1/1] PCI: qcom-ep: Do not enable resources during probe()
https://git.kernel.org/pci/pci/c/cd0b3e13ec30
Krzysztof