Re: [PATCH v6 1/2] HID: hid-goodix: Add Goodix HID-over-SPI driver

[Charles Wang]

Hi Doug,

Sorry for missing the "Reviewed-by" tag, will fix in v7.

On Tue, Aug 13, 2024 at 10:26:15AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Aug 13, 2024 at 6:37 AM Charles Wang <charles.goodix@xxxxxxxxx> wrote:
> >
> > This patch introduces a new driver to support the Goodix GT7986U
> > touch controller. This device is not compatible with Microsoft's
> > HID-over-SPI protocol and therefore needs to implement its own
> > flavor. The data reported is packaged according to the HID
> > protocol but uses SPI for communication to improve speed. This
> > enables the device to transmit not only coordinate data but also
> > corresponding raw data that can be accessed by user-space programs
> > through the hidraw interface. The raw data can be utilized for
> > functions like palm rejection, thereby improving the touch experience.
> >
> > Key features:
> > - Device connection confirmation and initialization
> > - IRQ-based event reporting to the input subsystem
> > - Support for HIDRAW operations (GET_REPORT and SET_REPORT)
> >
> > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx>
> > ---
> >  drivers/hid/Kconfig          |   6 +
> >  drivers/hid/Makefile         |   1 +
> >  drivers/hid/hid-goodix-spi.c | 810 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 817 insertions(+)
> >  create mode 100644 drivers/hid/hid-goodix-spi.c
> 
> As a point of reference, in v5 Dmitry gave you his "Reviewed-by" tag
> [1] despite having some nits. It's usually expected that you could fix
> the nits and carry the Reviewed-by tag on the next version unless you
> did something other than what was requested in review feedback.
> 
> [1] https://lore.kernel.org/all/ZoW4_hctu_cSiKA5@xxxxxxxxxx/

Thanks,

Charles