Re: [PATCH net-next 1/4] dt-bindings: net: dsa: microchip: add SGMII port support to KSZ9477 switch

[Krzysztof Kozlowski]

On 14/08/2024 01:09, Tristram.Ha@xxxxxxxxxxxxx wrote:
>> On 10/08/2024 01:38, Tristram.Ha@xxxxxxxxxxxxx wrote:
>>> From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>
>>>
>>> The SGMII module of KSZ9477 switch can be setup in 3 ways: 0 for direct
>>> connect, 1 for 1000BaseT SFP, and 2 for 10/100/1000 SFP.
>>
>> Binding should say it, not commit msg. But aren't you duplicating
>> something like phy-connection-type?
> 
> The sgmii-mode parameter is just used internally.  I am not sure using

This does not matter.

> phy-connection-type or phy-mode is appropriate.

Depends on what this property expressed in terms of hardware. Looks like
you want to say which SGMII mode is being used?



Best regards,
Krzysztof