Re: [PATCH 3/4] dt-bindings: net: bluetooth: qualcomm: add QCA9379 compatible
From: Krzysztof Kozlowski
Date: Wed Aug 14 2024 - 02:15:33 EST
On 14/08/2024 00:11, Felix Kaechele wrote:
> Thanks for taking a look, Krzysztof.
>
> In this case I think it would be easiest to just use the existing
> qca9377 fallback and drop his part of the patchset.
You need then other patchset documenting new compatible with fallback.
Compatibles are always specific.
https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst
>
> As for the supplies: For the particular module I am working with the
> supplies are mostly shared with the WiFi side. So it "just works"
> without taking care of supplies on the BT side.
You still should describe the hardware.
>
> But I agree it would be more correct to add and handle these as well.
> The documentation I have access to through the FCC filing of this module
> is not really conclusive of how to correctly name them in this context.
> I would rather avoid submitting a patch with incorrect supply names.
OK
Best regards,
Krzysztof