Re: [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit
From: Sunil V L
Date: Wed Aug 14 2024 - 02:29:43 EST
On Mon, Aug 12, 2024 at 06:47:02PM +0300, Andy Shevchenko wrote:
> Recent patch against this driver has been added without my review.
> It was technically my fault, however I was on long vacation.
> So, instead of blaming anyone, this small series to tidy up the things
> as I think would look and be maintainable better.
>
> Andy Shevchenko (7):
> serial: 8250_platform: Remove duplicate mapping
> serial: 8250_platform: Don't shadow error from
> serial8250_register_8250_port()
> serial: 8250_platform: Use same check for ACPI in the whole driver
> serial: 8250_platform: Tidy up ACPI ID table
> serial: 8250_platform: Switch to use platform_get_mem_or_io()
> serial: 8250_platform: Refactor serial8250_probe()
> serial: 8250_platform: Unify comment style
>
> drivers/tty/serial/8250/8250_platform.c | 107 +++++++++++++-----------
> 1 file changed, 58 insertions(+), 49 deletions(-)
>
Nice!. Thank you very much!.
For the series:
Reviewed-by: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>
Tested-by: Sunil V L <sunilvl@xxxxxxxxxxxxxxxx>
Thanks!
Sunil