Hi Badal,
+static intUsing a switch case in rev3 is more logical here. It will also simplify
+hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
+{
+ struct i915_hwmon *hwmon = ddat->hwmon;
+ struct hwm_fan_info *fi = &ddat->fi;
+ u32 reg_val, pulses, time, time_now;
+ intel_wakeref_t wakeref;
+ long rotations;
+ int ret = 0;
+
+ if (attr != hwmon_fan_input)
+ return -EOPNOTSUPP;
adding more fan attributes in the future. This is why switch cases are used
in other parts of the file.
it was my suggestion and to be honest I would rather prefer it
this way. I can understand it if we were expecting more cases in
the immediate, like it was in your case.
But I wouldn't have an ugly and unreadable one-case-switch in the
eventuality that something comes in the future. In that case, we
can always convert it.
Thanks,
Andi