Re: [PATCH v3 1/1] dt-bindings: hwmon: Add maxim max31790

[Chanh Nguyen]

On 13/08/2024 23:20, Krzysztof Kozlowski wrote:
> On 13/08/2024 10:41, Chanh Nguyen wrote:
> > Add device tree bindings and an example for max31790 device.
> >
> > Signed-off-by: Chanh Nguyen <chanh@xxxxxxxxxxxxxxxxxxxxxx>
>
>
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      fan-controller@21 {
> > +        compatible = "maxim,max31790";
> > +        reg = <0x21>;
> > +        clocks = <&sys_clk>;
> > +        resets = <&reset 0>;
>
> This node is incomplete. I asked to make the example complete, not by
> adding two incomplete examples or other ways... The binding description
> says this device controls fan. If so, where is the fan here?
>
> IOW, keep only one, complete example.
>
> Rest looks good. With this addressed (and optionally with maintainer
> change, which Conor asked):

Thank Krzysztof for your review!

I'll keep only complete example. I'm going to push patch v4 in the 
coming days.

Thanks,
Chanh

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof