On 14.08.2024 12:08 PM, Song Xue wrote:What is detailed information on smoke test.
On 8/9/2024 9:18 PM, Konrad Dybcio wrote:
X1E80100 has a multiport controller with 2 HS (eUSB) and 2 SS PHYs
attached to it. It's commonly used for USB-A ports and internally
routed devices. Configure it to support such functionality.
Signed-off-by: Konrad Dybcio<konrad.dybcio@xxxxxxxxxx>
---
[...]
+
+ phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>,
+ <&usb_mp_hsphy1>, <&usb_mp_qmpphy1>;
+ phy-names = "usb2-0", "usb3-0",
+ "usb2-1", "usb3-1";
+ dr_mode = "host";
Why do we add the dr_mode definition in dtsi file rather than in corresponding board dts file? Could we follow the node "usb_1_ss1_dwc3" in x1e80100-crd.dtsi?
That is because the MP controller is host-only and it doesn't make sense
to ensure the OS of that in each board file separately. That's also how
it's done on other platforms with a MP controller description.
BTW, how do we verify the function of multiport controller?From my test on x1e80100-crd, the eusb6 which is from usb_mp_hsphy1 attaches the third-party repeater, do we need a new repeater node/driver to verify the function of eusb6?
I have a X1E Surface Laptop 7 with a USB-A port with a NXP PTN3222 in
front of it. Tested with a smoke test, with both SS and HS USB-A devices.
Konrad