Re: [PATCH] phy: qualcomm: Check NULL ptr on data

From: Greg KH
Date: Wed Aug 14 2024 - 10:50:11 EST


On Wed, Aug 14, 2024 at 10:11:25PM +0800, Ma Ke wrote:
> Check NULL ptr on data, verify that data is not NULL before using it.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
> Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> index 06392ed7c91b..9b9fd9c1b1f7 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
> @@ -492,6 +492,8 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> data = of_device_get_match_data(&pdev->dev);
> + if (!data)
> + return -ENODEV;

When will this ever fail?