Re: [PATCH V2 02/10] accel/amdxdna: Support hardware mailbox

From: Jeffrey Hugo
Date: Wed Aug 14 2024 - 18:02:58 EST


On 8/14/2024 3:05 PM, Lizhi Hou wrote:

On 8/9/24 09:32, Jeffrey Hugo wrote:
On 8/5/2024 11:39 AM, Lizhi Hou wrote:
+static int mailbox_acquire_msgid(struct mailbox_channel *mb_chann, struct mailbox_msg *mb_msg)
+{
+    unsigned long flags;
+    int msg_id;
+
+    spin_lock_irqsave(&mb_chann->chan_idr_lock, flags);
+    msg_id = idr_alloc_cyclic(&mb_chann->chan_idr, mb_msg, 0,
+                  MAX_MSG_ID_ENTRIES, GFP_NOWAIT);
+    spin_unlock_irqrestore(&mb_chann->chan_idr_lock, flags);

I think an xa struct would be preferred.

Can we defer this? This is in critical path.

Ok. I would be satisfied with a high priority todo item for the conversion.

-Jeff