Re: [PATCH] usb: dwc3: ep0: Don't reset resource alloc flag (including ep0)

[Thinh Nguyen]

Hi Michael,

On Wed, Aug 14, 2024, Sergey Shtylyov wrote:
> On 8/14/24 11:42 PM, Sergey Shtylyov wrote:
> [...]
> 
> >> The DWC3_EP_RESOURCE_ALLOCATED flag ensures that the resource of an
> >> endpoint is only assigned once. Unless the endpoint is reset, don't
> >> clear this flag. Otherwise we may set endpoint resource again, which
> >> prevents the driver from initiate transfer after handling a STALL or
> >> endpoint halt to the control endpoint.
> >>
> >> Commit f2e0eee47038 (usb: dwc3: ep0: Don't reset resource alloc flag)
> > 
> >    You forgot the double quotes around the summary, the same as you
> > do in the Fixes tag.
> > 
> >> was fixing the initial issue, but did this only for physical ep1. Since
> >> the function dwc3_ep0_stall_and_restart is resetting the flags for both
> >> physical endpoints, this also has to be done for ep0.
> >>
> >> Cc: stable@xxxxxxxxxxxxxxx
> >> Fixes: b311048c174d ("usb: dwc3: gadget: Rewrite endpoint allocation flow")
> >> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>

Thanks for the catch!

If you send v2 for the double quote fix in the commit message, you can
include this:

Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>

BR,
Thinh