RE: [EXT] Re: [PATCH v2 40/43] wifi: nxpwifi: add wmm.h

From: David Lin
Date: Wed Aug 14 2024 - 21:52:34 EST


Hi Greg,

Following the guideline for new driver, it should let every file as a single patch for review and generate a final
single patch after reviewing. I think stuffs mentioned by you can be got from cover letter.

If I misunderstood anything, please let me know.

Thanks,
David

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, August 15, 2024 2:48 AM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; johannes@xxxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx;
> francesco@xxxxxxxxxx; Pete Hsieh <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH v2 40/43] wifi: nxpwifi: add wmm.h
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Fri, Aug 09, 2024 at 05:45:30PM +0800, David Lin wrote:
> > ---
> > drivers/net/wireless/nxp/nxpwifi/wmm.h | 78
> > ++++++++++++++++++++++++++
> > 1 file changed, 78 insertions(+)
> > create mode 100644 drivers/net/wireless/nxp/nxpwifi/wmm.h
>
>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a
> patch that has triggered this response. He used to manually respond to these
> common problems, but in order to save his sanity (he kept writing the same
> thing over and over, yet to different people), I was created. Hopefully you will
> not take offence and will fix the problem in your patch and resubmit it so that
> it can be accepted into the Linux kernel tree.
>
> You are receiving this message because of the following common error(s) as
> indicated below:
>
> - Your patch does not have a Signed-off-by: line. Please read the
> kernel file, Documentation/process/submitting-patches.rst and resend
> it after adding that line. Note, the line needs to be in the body of
> the email, before the patch, not at the bottom of the patch or in the
> email signature.
>
> - You did not specify a description of why the patch is needed, or
> possibly, any description at all, in the email body. Please read the
> section entitled "The canonical patch format" in the kernel file,
> Documentation/process/submitting-patches.rst for what is needed in
> order to properly describe the change.
>
> - You did not write a descriptive Subject: for the patch, allowing Greg,
> and everyone else, to know what this patch is all about. Please read
> the section entitled "The canonical patch format" in the kernel file,
> Documentation/process/submitting-patches.rst for what a proper
> Subject: line should look like.
>
> If you wish to discuss this problem further, or you have questions about how to
> resolve this issue, please feel free to respond to this email and Greg will reply
> once he has dug out from the pending patches received from other developers.
>
> thanks,
>
> greg k-h's patch email bot