Re: [PATCH 1/7] regulator: bd718x7: Use scoped device node handling to simplify error paths

From: Matti Vaittinen
Date: Thu Aug 15 2024 - 01:15:45 EST


On 8/14/24 18:04, Krzysztof Kozlowski wrote:
Obtain the device node reference with scoped/cleanup.h and use scoped
for_each_child_of_node_scoped() to reduce error handling and make the
code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Acked-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

Thanks Krzysztof! I've been a bit cautious to what comes to using the cleanup attribute. Well, I suppose it's a time for me to admit it simplifies things - even if it breaks the rules which were carved to a stone for a long time :) So ... Thanks!

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~