Re: [PATCH] bpf: Fix bpf_get/setsockopt to tos not take effect when TCP over IPv4 via INET6 API

[kernel test robot]

Hi Feng,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]
[also build test ERROR on bpf/master net-next/main net/main linus/master v6.11-rc3 next-20240815]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Feng-zhou/bpf-Fix-bpf_get-setsockopt-to-tos-not-take-effect-when-TCP-over-IPv4-via-INET6-API/20240814-231142
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20240814084504.22172-1-zhoufeng.zf%40bytedance.com
patch subject: [PATCH] bpf: Fix bpf_get/setsockopt to tos not take effect when TCP over IPv4 via INET6 API
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20240815/202408152034.lw9Ilsj6-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408152034.lw9Ilsj6-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408152034.lw9Ilsj6-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   alpha-linux-ld: net/core/filter.o: in function `sol_ip_sockopt':
>> net/core/filter.c:5402:(.text+0x8acc): undefined reference to `is_tcp_sock_ipv6_mapped'
>> alpha-linux-ld: net/core/filter.c:5402:(.text+0x8ad4): undefined reference to `is_tcp_sock_ipv6_mapped'
   alpha-linux-ld: net/core/filter.c:5402:(.text+0xc84c): undefined reference to `is_tcp_sock_ipv6_mapped'
   alpha-linux-ld: net/core/filter.c:5402:(.text+0xc858): undefined reference to `is_tcp_sock_ipv6_mapped'


vim +5402 net/core/filter.c

  5397	
  5398	static int sol_ip_sockopt(struct sock *sk, int optname,
  5399				  char *optval, int *optlen,
  5400				  bool getopt)
  5401	{
> 5402		if (sk->sk_family != AF_INET && !is_tcp_sock_ipv6_mapped(sk))
  5403			return -EINVAL;
  5404	
  5405		switch (optname) {
  5406		case IP_TOS:
  5407			if (*optlen != sizeof(int))
  5408				return -EINVAL;
  5409			break;
  5410		default:
  5411			return -EINVAL;
  5412		}
  5413	
  5414		if (getopt)
  5415			return do_ip_getsockopt(sk, SOL_IP, optname,
  5416						KERNEL_SOCKPTR(optval),
  5417						KERNEL_SOCKPTR(optlen));
  5418	
  5419		return do_ip_setsockopt(sk, SOL_IP, optname,
  5420					KERNEL_SOCKPTR(optval), *optlen);
  5421	}
  5422	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki