Re: [PATCH v3 05/13] PCI: endpoint: Assign PCI domain number for endpoint controllers
From: Manivannan Sadhasivam
Date: Thu Aug 15 2024 - 11:59:28 EST
On Sun, Aug 11, 2024 at 10:47:08AM +0800, kernel test robot wrote:
> Hi Manivannan,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on 8400291e289ee6b2bf9779ff1c83a291501f017b]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam-via-B4-Relay/PCI-qcom-ep-Drop-the-redundant-masking-of-global-IRQ-events/20240802-024847
> base: 8400291e289ee6b2bf9779ff1c83a291501f017b
> patch link: https://lore.kernel.org/r/20240731-pci-qcom-hotplug-v3-5-a1426afdee3b%40linaro.org
> patch subject: [PATCH v3 05/13] PCI: endpoint: Assign PCI domain number for endpoint controllers
> config: microblaze-randconfig-r072-20240810 (https://download.01.org/0day-ci/archive/20240811/202408111053.0PLHSTeH-lkp@xxxxxxxxx/config)
> compiler: microblaze-linux-gcc (GCC) 14.1.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408111053.0PLHSTeH-lkp@xxxxxxxxx/
>
> New smatch warnings:
> drivers/pci/endpoint/pci-epc-core.c:843 pci_epc_destroy() warn: inconsistent indenting
>
> Old smatch warnings:
> drivers/pci/endpoint/pci-epc-core.c:908 __pci_epc_create() warn: inconsistent indenting
>
Krzysztof, will you be able to fix the indendation while applying? If not,
please let me know. I'll spin v4.
- Mani
> vim +843 drivers/pci/endpoint/pci-epc-core.c
>
> 830
> 831 /**
> 832 * pci_epc_destroy() - destroy the EPC device
> 833 * @epc: the EPC device that has to be destroyed
> 834 *
> 835 * Invoke to destroy the PCI EPC device
> 836 */
> 837 void pci_epc_destroy(struct pci_epc *epc)
> 838 {
> 839 pci_ep_cfs_remove_epc_group(epc->group);
> 840 device_unregister(&epc->dev);
> 841
> 842 #ifdef CONFIG_PCI_DOMAINS_GENERIC
> > 843 pci_bus_release_domain_nr(NULL, &epc->dev);
> 844 #endif
> 845 }
> 846 EXPORT_SYMBOL_GPL(pci_epc_destroy);
> 847
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
--
மணிவண்ணன் சதாசிவம்