Re: [PATCH v2 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml
From: Dmitry Torokhov
Date: Thu Aug 15 2024 - 15:14:45 EST
On Thu, Aug 15, 2024 at 03:06:40PM -0400, Frank Li wrote:
> On Thu, Aug 15, 2024 at 08:44:56PM +0200, Marek Vasut wrote:
> > On 8/15/24 6:14 PM, Frank Li wrote:
> >
> > [...]
> >
> > > + ti,debounce-max:
> > > + deprecated: true
> > > + $ref: /schemas/types.yaml#/definitions/uint16
> > > + description: Max number of additional readings per sample (u16).
> >
> > Could you drop the (u16) which is already part of the $ref'd type ?
>
> Sorry, I forget it.
>
> >
> > [...]
> >
> > > + ti,x-max:
> > > + deprecated: true
> > > + $ref: /schemas/types.yaml#/definitions/uint16
> > > + description: Maximum value on the X axis (u16).
> > > +
> > > + ti,x-min:
> >
> > Is this deprecated too, the same way as x-max above is deprecated ?
>
> I am not sure. I guest x-min and y-min is still useful becasue it may
> indicate invalidated touch. but x-max and y-max should not usefull because
> max value should be Vcc. x-min and y-min help filter out some noise.
There are standard properties touchscreen-min-x and touchscreen-min-y
that will be used if present, so I think ti,x-min can also be marked as
deprecated.
Thanks.
--
Dmitry