Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too

[Yosry Ahmed]

On Thu, Aug 15, 2024 at 3:08 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 15 Aug 2024 12:12:26 -0700 Nhat Pham <nphamcs@xxxxxxxxx> wrote:
>
> > > Yeah, I thought about the other way around and reached the same
> > > conclusion.
> > > And there's permission boundary in the mix too - if root disables zswap
> > > writeback for its cgroup, the subcgroups, which could possibly be owned
> > > by other users, should not be able to reenable this.
> >
> > Hmm yeah, I think I agree with your and Yosry's reasonings :) It
> > doesn't affect our use case AFAICS, and the code looks solid to me,
> > so:
> >
> > Reviewed-by: Nhat Pham <nphamcs@xxxxxxxxx>
>
> But you'd still like an update to Documentation/admin-guide/cgroup-v2.rst?


Yeah I'd rather see a v2 with updated docs, and hopefully a selftest
if the existing tests problem is resolved.

Also, do we want a Fixes tag and to backport this so that current
users get the new behavior ASAP?