Re: [PATCH v4] libbpf: workaround -Wmaybe-uninitialized false positive
From: patchwork-bot+netdevbpf
Date: Thu Aug 15 2024 - 19:01:34 EST
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@xxxxxxxxxx>:
On Tue, 13 Aug 2024 20:49:06 +0100 you wrote:
> In `elf_close`, we get this with GCC 15 -O3 (at least):
> ```
> In function ‘elf_close’,
> inlined from ‘elf_close’ at elf.c:53:6,
> inlined from ‘elf_find_func_offset_from_file’ at elf.c:384:2:
> elf.c:57:9: warning: ‘elf_fd.elf’ may be used uninitialized [-Wmaybe-uninitialized]
> 57 | elf_end(elf_fd->elf);
> | ^~~~~~~~~~~~~~~~~~~~
> elf.c: In function ‘elf_find_func_offset_from_file’:
> elf.c:377:23: note: ‘elf_fd.elf’ was declared here
> 377 | struct elf_fd elf_fd;
> | ^~~~~~
> In function ‘elf_close’,
> inlined from ‘elf_close’ at elf.c:53:6,
> inlined from ‘elf_find_func_offset_from_file’ at elf.c:384:2:
> elf.c:58:9: warning: ‘elf_fd.fd’ may be used uninitialized [-Wmaybe-uninitialized]
> 58 | close(elf_fd->fd);
> | ^~~~~~~~~~~~~~~~~
> elf.c: In function ‘elf_find_func_offset_from_file’:
> elf.c:377:23: note: ‘elf_fd.fd’ was declared here
> 377 | struct elf_fd elf_fd;
> | ^~~~~~
> ```
>
> [...]
Here is the summary with links:
- [v4] libbpf: workaround -Wmaybe-uninitialized false positive
https://git.kernel.org/bpf/bpf-next/c/fab45b962749
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html