Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation_test

From: Kees Cook
Date: Thu Aug 15 2024 - 23:37:56 EST




On August 15, 2024 4:01:48 PM PDT, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>On Thu, 15 Aug 2024 01:04:31 +0100 Ivan Orlov <ivan.orlov0322@xxxxxxxxx> wrote:
>
>> The 'device_name' array doesn't exist out of the
>> 'overflow_allocation_test' function scope. However, it is being used as
>> a driver name when calling 'kunit_driver_create' from
>> 'kunit_device_register'. It produces the kernel panic with KASAN
>> enabled.
>>
>> Since this variable is used in one place only, remove it and pass the
>> device name into kunit_device_register directly as an ascii string.
>
>Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
>Cc: <stable@xxxxxxxxxxxxxxx>
>
>yes?
>
>
>I'll grab it now, but perhaps Kees will handle this.

I already grabbed it:
https://lore.kernel.org/lkml/172373928009.559695.8528767427266408069.b4-ty@xxxxxxxxxx/

But I'll update the tags. Thanks!

--
Kees Cook