Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding

From: Depeng Shao
Date: Fri Aug 16 2024 - 03:52:08 EST


Hi Krzysztof,

On 8/16/2024 3:01 PM, Krzysztof Kozlowski wrote:

+required:
+ - compatible
+ - clocks
+ - clock-names
+ - interconnects
+ - interconnect-names
+ - interrupts
+ - interrupt-names
+ - iommus
+ - power-domains
+ - power-domain-names
+ - reg
+ - reg-names
+ - vdda-phy-supply
+ - vdda-pll-supply

Order is still not as expected. I already commented on this - keep the
same order as in "properties:" block.

With the order fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Thanks for catching this, the order was correct in my local build, then Vladimir posted a new comment, so I updated it again and forgot to update the required item, I will correct the order in next version series.

Vladimir: "I would suggest to put 'compatible', 'reg' and 'reg-names' properties as the first ones. 'clock-names' should follow 'clocks' property in the list."

Thanks,
Depeng