Re: [PATCH v4 2/2] dma: add IOMMU static calls with clear default ops

[Christoph Hellwig]

On Fri, Aug 16, 2024 at 09:11:34AM +0200, Christoph Hellwig wrote:
> >>   +# DMA IOMMU uses common ops helpers for certain operations, so let's 
> >> allow to build
> >> +# ops_helpers.c even if DMA_OPS is not enabled
> >
> > Hmm, but actually dma-direct also uses dma_common_contiguous_remap(), so 
> > something seems a little inconsistent here...
> 
> Yes, but that's not really new.  I'll look into a patch to select
> the helpers based on the conditions that make dma-direct use it.
> 
> I'll fix up all style issues and will apply the patch with that over
> the weekend so that we can get it into this merge window.

It turns out dma_common_contiguous_remap sits in kernel/dma/remap.c,
which is always built when CONFIG_MMU is set, so this isn't an
issue.  Maybe I need to clean up the namespaces a bit..