Re: wifi: mwifiex: duplicate static structs used in driver instances

From: Kalle Valo
Date: Fri Aug 16 2024 - 05:48:23 EST


Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote:

> mwifiex_band_2ghz and mwifiex_band_5ghz are statically allocated, but
> used and modified in driver instances. Duplicate them before using
> them in driver instances so that different driver instances do not
> influence each other.
>
> This was observed on a board which has one PCIe and one SDIO mwifiex
> adapter. It blew up in mwifiex_setup_ht_caps(). This was called with
> the statically allocated struct which is modified in this function.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: d6bffe8bb520 ("mwifiex: support for creation of AP interface")
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> Acked-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Patch applied to wireless.git, thanks.

27ec3c57fcad wifi: mwifiex: duplicate static structs used in driver instances

--
https://patchwork.kernel.org/project/linux-wireless/patch/20240809-mwifiex-duplicate-static-structs-v1-1-6837b903b1a4@xxxxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches