Re: [PATCH 5.4 000/259] 5.4.282-rc1 review

[Greg Kroah-Hartman]

On Fri, Aug 16, 2024 at 11:01:53AM +0200, Anders Roxell wrote:
> On Thu, 15 Aug 2024 at 16:12, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This is the start of the stable review cycle for the 5.4.282 release.
> > There are 259 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 17 Aug 2024 13:18:17 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.282-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> The following S390 build failed on stable-rc 5.4.y with gcc-12 due
> to following warnings and errors [1].
> 
> s390:
>   build:
>     * gcc-8-defconfig-fe40093d
>     * gcc-12-defconfig
> 
> Bisect point to deb23146ba03 ("s390/pci: fix CPU address in MSI for
> directed IRQ")
> as the problematic commit [ Upstream commit
> a2bd4097b3ec242f4de4924db463a9c94530e03a ].
> 
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> 
> Build log:
> ------
> /builds/linux/arch/s390/pci/pci_irq.c: In function 'zpci_set_irq_affinity':
> /builds/linux/arch/s390/pci/pci_irq.c:106:17: error: implicit
> declaration of function 'smp_cpu_get_cpu_address'; did you mean
> 'device_get_mac_address'? [-Werror=implicit-function-declaration]
>   int cpu_addr = smp_cpu_get_cpu_address(cpumask_first(dest));
>                  ^~~~~~~~~~~~~~~~~~~~~~~
>                  device_get_mac_address
> /builds/linux/arch/s390/pci/pci_irq.c: In function 'arch_setup_msi_irqs':
> /builds/linux/arch/s390/pci/pci_irq.c:298:2: error: implicit
> declaration of function 'msi_for_each_desc'; did you mean
> 'bus_for_each_dev'? [-Werror=implicit-function-declaration]
>   msi_for_each_desc(msi, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
>   ^~~~~~~~~~~~~~~~~
>   bus_for_each_dev
> /builds/linux/arch/s390/pci/pci_irq.c:298:37: error:
> 'MSI_DESC_NOTASSOCIATED' undeclared (first use in this function)
>   msi_for_each_desc(msi, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
>                                      ^~~~~~~~~~~~~~~~~~~~~~
> /builds/linux/arch/s390/pci/pci_irq.c:298:37: note: each undeclared
> identifier is reported only once for each function it appears in
> /builds/linux/arch/s390/pci/pci_irq.c:298:60: error: expected ';'
> before '{' token
>   msi_for_each_desc(msi, &pdev->dev, MSI_DESC_NOTASSOCIATED) {
>                                                             ^~

Thanks, will go drop the offending commits and push out a -rc2

greg k-h