Re: [PATCH net-next] net: remove redundant check in skb_shift()

[Simon Horman]

On Thu, Aug 15, 2024 at 10:09:42PM +0800, Zhang Changzhong wrote:
> The check for '!to' is redundant here, since skb_can_coalesce() already
> contains this check.

It would be nice to mention here how this was found (e.g. found by
inspection, flagged by private static analysis tool, ...) and how it was
tested (e.g. compile tested only).

> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>

In any case, this looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>