Re: [PATCH 1/1] iommu/vt-d: Move PCI PASID enablement to probe path

From: Jason Gunthorpe
Date: Fri Aug 16 2024 - 09:32:47 EST


On Fri, Aug 16, 2024 at 09:09:04PM +0800, Baolu Lu wrote:
> On 2024/8/16 20:16, Vasant Hegde wrote:
> > On 8/16/2024 4:19 PM, Lu Baolu wrote:
> > > Currently, PCI PASID is enabled alongside PCI ATS when an iommu domain is
> > > attached to the device and disabled when the device transitions to block
> > > translation mode. This approach is inappropriate as PCI PASID is a device
> > > feature independent of the type of the attached domain.
> > Reading through other thread, I thought we want to enable both PASID and PRI in
> > device probe path. Did I miss something?
>
> PRI is different. PRI should be enabled when the first iopf-capable
> domain is attached to device or its PASID, and disabled when the last
> such domain is detached.

+1

Jason