Re: (subset) [PATCH] leds: pca995x: Fix device child node usage in pca995x_probe()
From: Lee Jones
Date: Fri Aug 16 2024 - 12:01:48 EST
On Wed, 07 Aug 2024 15:37:03 +0200, Javier Carrasco wrote:
> The current implementation accesses the `child` fwnode handle outside of
> device_for_each_child_node() without incrementing its refcount.
>
> Add the missing call to `fwnode_handle_get(child)`.
>
> The cleanup process where `child` is accessed is not right either
> because a single call to `fwnode_handle_put()` is carried out in case of
> an error, ignoring unasigned nodes at the point when the error happens.
>
> [...]
Applied, thanks!
[1/1] leds: pca995x: Fix device child node usage in pca995x_probe()
commit: 82c5ada1f9d05902a4ccb926c7ce34e2fe699283
--
Lee Jones [李琼斯]