Re: [PATCH 3/6] kbuild: rust: re-run Kconfig if the version text changes

From: Miguel Ojeda
Date: Sat Aug 17 2024 - 09:28:40 EST


On Sat, Aug 17, 2024 at 2:58 PM Nicolas Schier <nicolas@xxxxxxxxx> wrote:
>
> If you send a v2, mind you consider reformatting so that this comment
> block stays <= 80 chars?

Sure.

> Do we already support rust in external kernel modules? In top-level

If you mean out-of-tree modules, then yeah, they should generally work
(at least I test the build with a trivial one regularly, but perhaps
it is missing something), although they are not the highest priority.

> Makefile's oot-kmod 'prepare' target we check that the compiler
> (version) is the same as when the kernel itself was built. If rust
> modules are supported, adding a similar check might be helpful.

That is a good point, I will take a look.

> Reviewed-by: Nicolas Schier <nicolas@xxxxxxxxx>

Thanks!

Cheers,
Miguel