Re: [PATCH v2] kbuild: add debug package to pacman PKGBUILD

[Jose Fernandez]

On 24/08/17 07:15PM, Thomas Weißschuh wrote:
> On 2024-08-17 09:11:47+0000, Jose Fernandez wrote:
> > Add a new debug package to the PKGBUILD for the pacman-pkg target. The
> > debug package includes the non-stripped vmlinux file, providing access
> > to debug symbols needed for kernel debugging and profiling. The vmlinux
> > file will be installed to /usr/src/debug/${pkgbase}. The debug package
> > will be built by default and can be excluded by overriding PACMAN_EXTRAPACKAGES.
> > 
> > Signed-off-by: Jose Fernandez <jose.fernandez@xxxxxxxxx>
> > Reviewed-by: Peter Jung <ptr1337@xxxxxxxxxxx>
> > ---
> > v1->v2:
> > - Use the new PACMAN_EXTRAPACKAGES [1] variable to allow users to disable the
> > debug package if desired, instead of always including it.
> > 
> > [1] https://lore.kernel.org/lkml/20240813185900.GA140556@thelio-3990X/T/
> > 
> >  scripts/package/PKGBUILD | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> > index fbd7eb10a52c..d40d282353de 100644
> > --- a/scripts/package/PKGBUILD
> > +++ b/scripts/package/PKGBUILD
> > @@ -5,7 +5,7 @@
> >  pkgbase=${PACMAN_PKGBASE:-linux-upstream}
> >  pkgname=("${pkgbase}")
> >  
> > -_extrapackages=${PACMAN_EXTRAPACKAGES-headers api-headers}
> > +_extrapackages=${PACMAN_EXTRAPACKAGES-headers api-headers debug}
> >  for pkg in $_extrapackages; do
> >  	pkgname+=("${pkgbase}-${pkg}")
> >  done
> > @@ -106,6 +106,15 @@ _package-api-headers() {
> >  	${MAKE} headers_install INSTALL_HDR_PATH="${pkgdir}/usr"
> >  }
> >  
> > +_package-debug(){
> > +	pkgdesc="Non-stripped vmlinux file for the ${pkgdesc} kernel"
> > +	depends=(${pkgbase}-headers)
> > +
> > +	cd "${objtree}"
> 
> This should make use of _prologue() from 
> "kbuild: pacman-pkg: move common commands to a separate function"
> 
> https://lore.kernel.org/lkml/20240816141844.1217356-1-masahiroy@xxxxxxxxxx/
> 
> It's not yet part of the kbuild tree, but I guess will be soon.

Ack. I'll wait for that to be merged before I send out v3.

> > +	mkdir -p "$pkgdir/usr/src/debug/${pkgbase}"
> 
> The mkdir shouldn't be necessary, as install -D is used.
> 
> > +	install -Dt "$pkgdir/usr/src/debug/${pkgbase}" -m644 vmlinux

I'll remove the mkdir line in v3.

> Can you also add a symlink to /usr/lib/modules/$(uname -r)/build/vmlinux
> for compatibility with the vanilla package?

Yes, will do.

> > +}
> > +
> >  for _p in "${pkgname[@]}"; do
> >  	eval "package_$_p() {
> >  		$(declare -f "_package${_p#$pkgbase}")
> > 
> > base-commit: 869679673d3bbaaf1c2a43dba53930f5241e1d30
> > -- 
> > 2.46.0
> >