Re: [PATCH] HID: corsair-void: Add Corsair Void headset family driver

From: Markus Elfring
Date: Sun Aug 18 2024 - 09:13:19 EST


How do you think about to distinguish properties any further for available
device attributes?
https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/driver-api/driver-model/device.rst#L38



> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,851 @@

> +static DEVICE_ATTR(fw_version_receiver, 0444, corsair_void_report_firmware, NULL);
> +static DEVICE_ATTR(fw_version_headset, 0444, corsair_void_report_firmware, NULL);

* Are these really changeable?

* Can the macro “DEVICE_ATTR_RO” be applied?



> +MODULE_AUTHOR("Stuart Hayhurst");

Would you like to add an email address here?

Regards,
Markus