Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

From: Miguel Ojeda
Date: Sun Aug 18 2024 - 19:41:07 EST


On Sun, Aug 18, 2024 at 2:49 AM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
>
> Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>
>
> This also passed my test script (x86, arm64 and riscv build and kunit
> tests).

Hmm... I think you either tested another one, or you manually fixed
the dependency (`$(obj)/helpers/helpers.o`).

Or am I confused?

> Miguel, I think it makes more sense if we take this one and the
> helpers.c split one as early as possible, given they are treewide
> changes ;-)

Agreed, we should take it soon. I have rebased it on top of
`rust-next` and fixed the dependency.

Please take a look:

https://github.com/Rust-for-Linux/linux/commit/0d6e3e8d3677ee7b5cccf9bc002e18f140c02a4e

I will put it in after we confirm we are not confused :) (and after we
get a linux-next round or two for what is currently there).

Extra `Tested-by`s would be nice!

Cheers,
Miguel