Re: [PATCH v2] kbuild: rust: auto generate rust helper exports

From: Miguel Ojeda
Date: Sun Aug 18 2024 - 20:17:30 EST


On Mon, Aug 19, 2024 at 1:56 AM Gary Guo <gary@xxxxxxxxxxx> wrote:
>
> It's the mistake on my patch. I noticed the exact issue while I was
> trying to rebase my helper-lto patch :)
>
> I believe that reason that it builds fine for me previously and for
> Boqun was that we didn't delete the helpers.o generated prior to
> applying the helper split patch, and we know that kbuild is not
> hermetic.

Yeah, probably it was that -- as you say, it would require a stale
`rust/helpers.o` from a build before Andreas' patch (and not just
before this patch).

> Your rebase and the fix is identical to the one I got locally, and I
> can confirm that it compiles fine for a clean build.

Thanks a lot for taking a look!

Cheers,
Miguel