Re: [PATCH -next] spi: bcm63xx: Fix module autoloading

From: Jonas Gorski
Date: Mon Aug 19 2024 - 03:47:45 EST


Hi,

On Mon, 19 Aug 2024 at 05:59, Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:
>
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.

Your code change adds a MODULE_DEVICE_TABLE() to platform_device_id,
not of_device_id (which is also missing it). Please align change and
message.

Also since this is a fix, please add an appropriate Fixes tag and Cc stable.

>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

Apart from that the change looks good.

Reviewed-by: Jonas Gorski <jonas.gorski@xxxxxxxxx>

Best Regards,
Jonas