Re: [PATCH v3 3/5] dt-bindings: arm: Add Coresight TMC Control Unit hardware

[Krzysztof Kozlowski]

On 19/08/2024 11:06, JieGan wrote:
> On Mon, Aug 19, 2024 at 08:26:19AM +0200, Krzysztof Kozlowski wrote:
>> On 12/08/2024 04:41, Jie Gan wrote:
>>> +
>>> +maintainers:
>>> +  - Yuanfang Zhang <quic_yuanfang@xxxxxxxxxxx>
>>> +  - Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
>>> +  - Jie Gan <quic_jiegan@xxxxxxxxxxx>
>>> +
>>> +description:
>>> +  The Coresight TMC Control unit controls various Coresight behaviors.
>>> +  It works as a helper device when connected to TMC ETR device.
>>> +  It is responsible for controlling the data filter function based on
>>> +  the source device's Trace ID for TMC ETR device. The trace data with
>>> +  that Trace id can get into ETR's buffer while other trace data gets
>>> +  ignored.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - qcom,sa8775p-ctcu
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: apb
>>> +
>>> +  in-ports:
>>> +    $ref: /schemas/graph.yaml#/properties/ports
>>> +
>>> +    patternProperties:
>>> +      '^port(@[0-7])?$':
>>
>> I see only two ports in the example. How many are there in reality?
> Existing projects can have a maximum of two ports. I used the range 0-7 as I consider
> it unlikely to have more than 8 ports. Maybe it's intended as a large buffer for
> futher design needs.

Please do not create buffers in the bindings. This must be specific, so [01]

Best regards,
Krzysztof