Re: [PATCH v3 03/10] x86/tdx: Allow MMIO from userspace

From: Alexey Gladkov
Date: Mon Aug 19 2024 - 07:51:17 EST


On Mon, Aug 19, 2024 at 01:46:34PM +0300, Kirill A. Shutemov wrote:
> On Fri, Aug 16, 2024 at 03:43:53PM +0200, Alexey Gladkov wrote:
> > From: "Alexey Gladkov (Intel)" <legion@xxxxxxxxxx>
> >
> > The MMIO emulation is only allowed for kernel space code. It is carried
> > out through a special API, which uses only certain instructions.
> >
> > This does not allow userspace to work with virtual devices.
> >
> > Allow userspace to use the same instructions as kernel space to access
> > MMIO. So far, no additional checks have been made.
> >
> > Signed-off-by: Alexey Gladkov (Intel) <legion@xxxxxxxxxx>
>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> And you seem to lost Reviewed-by from Thomas:
>
> https://lore.kernel.org/all/874j867mnd.ffs@tglx

No. I removed it because the patch changed a lot after his review. I
didn't want to mislead anyone.

--
Rgrds, legion