Re: [PATCH -next 9/9] ipmi: ipmi_ssif: fix module autoloading

From: Arnd Bergmann
Date: Mon Aug 19 2024 - 08:03:38 EST


On Mon, Aug 19, 2024, at 13:38, Yuntao Liu wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from platform_device_id table.
>
> Signed-off-by: Yuntao Liu <liuyuntao12@xxxxxxxxxx>
> ---

The driver already has a MODULE_ALIAS() with the same string.

I think the MODULE_DEVICE_TABLE() entry is slightly cleaner here,
but it should only have one of the two, not both.

Arnd