Re: [PATCH v5 3/4] PCI: Decouple D3Hot and D3Cold handling for bridges

From: Oliver Neukum
Date: Mon Aug 19 2024 - 08:44:57 EST


On 02.08.24 07:55, Manivannan Sadhasivam via B4 Relay wrote:

--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -1434,7 +1434,7 @@ void pci_acpi_setup(struct device *dev, struct acpi_device *adev)
* reason is that the bridge may have additional methods such as
* _DSW that need to be called.
*/
- if (pci_dev->bridge_d3_allowed)
+ if (pci_dev->bridge_d3cold_allowed && pci_dev->bridge_d3hot_allowed)

Are you sure you want to require both capabilities here?

Regards
Oliver