Re: [PATCH 03/14] Input: samsung-keypad - do not combine memory allocation checks

From: Krzysztof Kozlowski
Date: Mon Aug 19 2024 - 08:52:48 EST


On Sun, Aug 18, 2024 at 09:58:00PM -0700, Dmitry Torokhov wrote:
> The driver uses devm API to allocate resources so there's no reason
> to do allocations first and then check and release everything at once.
>
> Check results immediately after doing allocation of each resource.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/input/keyboard/samsung-keypad.c | 5 ++++-

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof