Re: [PATCH] arm-cci: Fix refcount leak in cci_probe

From: Suzuki K Poulose
Date: Mon Aug 19 2024 - 10:29:05 EST


On 19/08/2024 10:04, Ma Ke wrote:
Add the missing of_node_put() to release the refcount incremented
by of_find_matching_node().

Cc: stable@xxxxxxxxxxxxxxx
Fixes: f6b9e83ce05e ("arm-cci: Rearrange code for splitting PMU vs driver code")
Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
---
drivers/bus/arm-cci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..6be7b05b5ff1 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -548,6 +548,7 @@ static int cci_probe(void)
}
if (ret || !cci_ctrl_base) {
WARN(1, "unable to ioremap CCI ctrl\n");
+ of_node_put(np);
return -ENXIO;
}

Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>