Re: [PATCH net-next 2/2] net: dsa: microchip: add KSZ8 change_tag_protocol support

From: Pieter
Date: Mon Aug 19 2024 - 10:59:21 EST


Hi Vladimir,

> > It works as you said, I will have to do some changes to userspace to
> > ensure the DHCP client uses br0 instead of eth0 but that's it.
> > I just tried and br0 obtains the IP address and all is good, with
> > DSA tagging enabled.
> >
> > This patch can be dropped, sorry for the hassle.
>
> I'm pretty baffled. Was this unclear from the user documentation at:
> https://www.kernel.org/doc/html/next/networking/dsa/configuration.html
> ? Maybe we should change something to make it more clear that this is
> what is expected.

It was to me but that's rather due to my limited knowledge of the network
stack and routing than to the quality of that documentation per se.

Cheers, Pieter