Re: [PATCH v2 4/7] net: phy: add helper for mapping RGMII link speed to clock rate

[Andrew Lunn]

On Sun, Aug 18, 2024 at 09:50:46PM +0000, Jan Petrous (OSS) wrote:
> The helper rgmii_clock() implemented Russel's hint during stmmac
> glue driver review:
> 
> ---
> We seem to have multiple cases of very similar logic in lots of stmmac
> platform drivers, and I think it's about time we said no more to this.
> So, what I think we should do is as follows:
> 
> add the following helper - either in stmmac, or more generically
> (phylib? - in which case its name will need changing.)

As Russell pointed out, this code appears a few times in the stmmac
driver. Please include patches changing the other instances to use
this helper.

It also looks like macb, and maybe xgene_enet_hw.c could use it as
well.

	Andrew