Re: [PATCH] drm/panel: mantix-mlaf057we51: transition to mipi_dsi wrapped functions

[neil . armstrong]

On 19/08/2024 18:14, Doug Anderson wrote:
> Hi,
>
> On Mon, Aug 19, 2024 at 8:36 AM <neil.armstrong@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 18/08/2024 09:23, Tejas Vipin wrote:
> > > Changes the mantix-mlaf057we51 panel to use multi style functions for
> > > improved error handling.
> > >
> > > Signed-off-by: Tejas Vipin <tejasvipin76@xxxxxxxxx>
> > > ---
> > >    .../gpu/drm/panel/panel-mantix-mlaf057we51.c  | 79 +++++++------------
> > >    1 file changed, 27 insertions(+), 52 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> > > index ea4a6bf6d35b..4db852ffb0f6 100644
> > > --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> > > +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> > > @@ -23,7 +23,7 @@
> > >
> > >    /* Manufacturer specific Commands send via DSI */
> > >    #define MANTIX_CMD_OTP_STOP_RELOAD_MIPI 0x41
> > > -#define MANTIX_CMD_INT_CANCEL           0x4C
> > > +#define MANTIX_CMD_INT_CANCEL           0x4c
> >
> > Please move cleanups to separate patches
>
> LOL, in a previous patch series I had the upper-to-lowercase in a
> separate patch and someone yelled at me to do the opposite and squash
> it together [1]. It doesn't really matter too much to me, but given
> the previous feedback I've just been suggesting that Tejas squash it
> together with his conversions. I'm OK either way, though.

Yeah it heavily depends on the rename, but I guess here it's fine to be applied as-is!

Neil

> [1] https://lore.kernel.org/r/CAA8EJpo4WzMPNjpnkHt-_GJe2TAF_i_G+eTaJrGipMEzppc3rQ@xxxxxxxxxxxxxx
>
> -Doug