Re: [PATCH v6 00/13] PCI: brcnstb: Enable STB 7712 SOC

[Florian Fainelli]

On 8/19/24 10:44, Jim Quinlan wrote:
> On Fri, Aug 16, 2024 at 3:18 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@xxxxxxxxxx> wrote:
> > On Thu, Aug 15, 2024 at 06:57:13PM -0400, Jim Quinlan wrote:
> > > V6 Changes
> > >    o Commit "Refactor for chips with many regular inbound windows"
> > >      -- Use u8 for anything storing/counting # inbound windows (Stan)
> > >      -- s/set_bar/add_inbound_win/g (Manivannan)
> > >      -- Drop use of "inline" (Manivannan)
> > >      -- Change cpu_beg to cpu_start, same with pcie_beg. (Manivannan)
> > >      -- Used writel_relaxed() (Manivannan)
> > >    o Use swinit reset if available
> > >      -- Proper use of dev_err_probe() (Stan)
> > >    o Commit "Use common error handling code in brcm_pcie_probe()"
> > >      -- Rewrite commit msg in paragraph form (Manivannan)
> > >      -- Refactor error path at end of probe func (Manivannan)
> > >      -- Proper use of dev_err_probe() (Stan)
> > >    o New commit "dt-bindings: PCI: Change brcmstb maintainer and cleanup"
> > >      -- Break out maintainer change and small cleanup into a
> > >         separate commit (Krzysztof)
> >
> > Looks like you've missed adding the review tags...
>
>
> I didn't mention this in the cover letter but I update the review tags
> at each version.  The problem is that if someone has reviewed a
> commit, and then that commit is subsequently changed due to another
> reviewer, I have to remove the existing tag of the first reviewer
> because the code has changed.

It seems to me like you did the right thing here, the changes you did 
between v5 and v6 were substantial enough they invalidated the 
Reviewed-by tag(s) you had gotten previously.
--
Florian