Re: [PATCH 5/5] alloc_tag: config to store page allocation tag refs in page flags
From: Matthew Wilcox
Date: Mon Aug 19 2024 - 16:41:09 EST
On Mon, Aug 19, 2024 at 01:39:16PM -0700, Suren Baghdasaryan wrote:
> On Mon, Aug 19, 2024 at 12:34 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> > So if ALLOC_TAG_REF_WIDTH is big enough, it's going to force last_cpupid
> > into struct page.
>
> Thanks for taking a look!
> Yes, but how is this field different from say KASAN_TAG_WIDTH which
> can also force last_cpupid out of page flags?
Because KASAN isn't for production use?
> > That will misalign struct page and disable HVO -- with no warning!
>
> mminit_verify_pageflags_layout already has a mminit_dprintk() to
> indicate this condition. Is that not enough?
Fair.