Re: [PATCH net-next v1 1/3] ethtool: Extend cable testing interface with result source information

[Andrew Lunn]

> @@ -573,15 +573,25 @@ enum {
>  	ETHTOOL_A_CABLE_RESULT_UNSPEC,
>  	ETHTOOL_A_CABLE_RESULT_PAIR,		/* u8 ETHTOOL_A_CABLE_PAIR_ */
>  	ETHTOOL_A_CABLE_RESULT_CODE,		/* u8 ETHTOOL_A_CABLE_RESULT_CODE_ */
> +	ETHTOOL_A_CABLE_RESULT_SRC,		/* u32 */

Please follow the convention of given the prefix of values,
ETHTOOL_A_CABLE_INF_SRC_ in the comment. I also wounder if a u8 would
be more in keeping with the API. _PAIR and _CODE are u8.

	Andrew