Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

From: Matthew Maurer
Date: Mon Aug 19 2024 - 19:41:53 EST


On Fri, Aug 16, 2024 at 4:04 PM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>
> Matthew Maurer <mmaurer@xxxxxxxxxx> writes:
> > Adds a new format for MODVERSIONS which stores each field in a separate
> > ELF section. This initially adds support for variable length names, but
> > could later be used to add additional fields to MODVERSIONS in a
> > backwards compatible way if needed. Any new fields will be ignored by
> > old user tooling, unlike the current format where user tooling cannot
> > tolerate adjustments to the format (for example making the name field
> > longer).
> >
> > Since PPC munges its version records to strip leading dots, we reproduce
> > the munging for the new format.
>
> AFAICS the existing code only strips a single leading dot, not all
> leading dots?

You appear to be correct, I'll update that in the next version, but
want to wait for more feedback on the rest of the patchset before
sending up another full series.

>
> cheers