Re: [PATCH v4 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

[Marek Vasut]

On 8/19/24 8:05 PM, Frank Li wrote:

[...]

> +  ti,keep-vref-on:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      set to keep Vref on for differential measurements as well.

Please start sentence with uppercase letter.

> +  ti,pendown-gpio-debounce:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Platform specific debounce time for the pendown-gpio.
> +
> +  ti,penirq-recheck-delay-usecs:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      If set to non-zero, after samples are taken this delay is applied and
> +      penirq is rechecked, to help avoid false events.  This value is
> +      affected by the material used to build the touch layer.
> +
> +  ti,pressure-max:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Maximum reported pressure value.
> +
> +  ti,pressure-min:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Minimum reported pressure value (threshold).
> +
> +  ti,settle-delay-usec:
> +    $ref: /schemas/types.yaml#/definitions/uint16
> +    description:
> +      Settling time of the analog signals; a function of Vcc and the
> +      capacitance on the X/Y drivers.  If set to non-zero, two samples are
> +      taken with settle_delay us apart, and the second one is used. ~150
> +      uSec with 0.01uF caps.
> +
> +  ti,swap-xy:
> +    deprecated: true
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      swap x and y axis.

DTTO

With those two fixed:

Reviewed-by: Marek Vasut <marex@xxxxxxx>

Thanks !