Re: regression: 9eac534db001 ("firmware/sysfb: Set firmware-framebuffer parent device") broke nomodeset boot?

From: Mike Galbraith
Date: Mon Aug 19 2024 - 23:48:55 EST


On Tue, 2024-08-20 at 03:31 +0200, Mike Galbraith wrote:
>
> I haven't yet tried reverting the series...

Hey, how 'bout that, applying a mallot is not only easier, it works :)

---
drivers/firmware/sysfb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/firmware/sysfb.c
+++ b/drivers/firmware/sysfb.c
@@ -95,6 +95,7 @@ static __init bool sysfb_pci_dev_is_enab

static __init struct device *sysfb_parent_dev(const struct screen_info *si)
{
+#ifdef MEH_WHAT_COULD_GO_WRONG
struct pci_dev *pdev;

pdev = screen_info_pci_dev(si);
@@ -107,7 +108,7 @@ static __init struct device *sysfb_paren
}
return &pdev->dev;
}
-
+#endif
return NULL;
}