Re: [v2] HID: corsair-void: Add Corsair Void headset family driver
From: Markus Elfring
Date: Tue Aug 20 2024 - 01:56:49 EST
>> * Would you like to reduce scopes for such local variables?
>
> I thought the kernel programming style put the local variables at the
> start of the function?
This was the case for a while.
Increasing applications of scope-based resource management provide
further opportunities for smaller scopes according to some local variables,
don't they?
>> Can such a size determination be explained better?
>
> Well it allocates 3 bytes and immediately fills them, so I'm not sure
> what I'd write except stating the obvious.
> Unless you mean why it has to be allocated rather than just using the stack?
How do you think about to collaborate with other data structures
than character arrays?
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.11-rc4#n953
Regards,
Markus