Re: [PATCH 1/2] x86/kexec: Fix a comment of swap_pages() assembly

[Kirill A. Shutemov]

On Tue, Aug 20, 2024 at 12:21:11AM +1200, Kai Huang wrote:
> When relocate_kernel() gets called, %rdi holds 'indirection_page' and
> %rsi holds 'page_list'.  And %rdi always holds 'indirection_page' when
> swap_pages() is called.
> 
> Therefore the comment of the first line code of swap_pages()
> 
> 	movq    %rdi, %rcx      /* Put the page_list in %rcx */
> 
> .. isn't correct because it actually moves the 'indirection_page' to
> the %rcx.  Fix it.
> 
> Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Looks like it got broken by 4bfaaef01a1b ("[PATCH] Avoid overwriting the
current pgd (V4, x86_64)")

-- 
  Kiryl Shutsemau / Kirill A. Shutemov