Re: [PATCH v3] HID: corsair-void: Add Corsair Void headset family driver

From: Markus Elfring
Date: Tue Aug 20 2024 - 05:17:29 EST



> +++ b/drivers/hid/hid-corsair-void.c
> @@ -0,0 +1,842 @@

> +static int corsair_void_set_sidetone_wireless(struct device *dev, const char *buf,
> + unsigned char sidetone)
> +{

> + int ret = 0;

> + ret = hid_hw_raw_request(hid_dev, CORSAIR_VOID_SIDETONE_REQUEST_ID,
> + send_buf, 12, HID_FEATURE_REPORT,
> + HID_REQ_SET_REPORT);
> +
> + return ret;
> +}

Would you like to return the value directly (without an intermediate local variable)?

Regards,
Markus